chore: implement parquet error handling for object_store #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Make sense to me. Thank you for the contrbution @abhiaagarwal 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Very small change I made when I was working on implementing
ParquetObjectWriter, but someone else already had it so I want to upstream this small fix I made.What changes are included in this PR?
Implements
object_store::Errorfor ParquetError. In delta-rs,ParquetRecordBatchStreamBuilderis failing pretty often (#5882) when dealing with large tables on s3, so this turns that error into a BoxedError that can be propagated upwards and inspected.Are there any user-facing changes?
No