Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParquetError::NeedMoreData #6630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 25, 2024

Which issue does this PR close?

Part of #6447.

Rationale for this change

ParquetMetaDataReader currently uses ParquetError::IndexOutOfBound to indicate the need for more data. This is not the intended use for IndexOutOfBound.

What changes are included in this PR?

Adds a new enum value NeedMoreData.

Are there any user-facing changes?

Yes, this changes the ParquetError API as well as ParquetMetaDataReader.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 25, 2024
@tustvold tustvold added api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants