arrow-cast: Support FixedSizeBinary packing #6666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft as this is not waiting on any more feedback -- please mark it as ready for review when it is time. Extending the existing tests should be straightforward -- let us know if you need help @metalmatze Thanks for the contribution |
|
Thanks, everyone! |
Perhaps you could follow the model of arrow-rs/arrow-cast/src/cast/mod.rs Line 6795 in 3ee5048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6665.
Rationale for this change
The added code seems to be where the casting and packing is handled.
What changes are included in this PR?
Are there any user-facing changes?
No, I don't think so.