Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add comments explaining bad MSRV, output in json #6857

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 7, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

While debugging #6853 with @andygrove and @viirya , the CI output display for MSRV failures look 🤮 and doesn't tell you what the problem is

https://github.com/apache/arrow-rs/actions/runs/12207850027/job/34060002164?pr=6853

Screenshot 2024-12-07 at 7 42 10 AM

I also tried improving the output display here but it doesn't seem to display the error to logs

What changes are included in this PR?

  1. Add comments explaining what to do on failure
  2. Change the output to JSON which at least has the actual error in the string, even if it is somewhat hard to see

Here is an example failure message from https://github.com/apache/arrow-rs/actions/runs/12215692321/job/34077953686?pr=6857

{"type":"subcommand_result","subcommand_id":"verify","result":{"toolchain":{"version":"1.70.0","target":"x86_64-unknown-linux-gnu","components":[]},"is_compatible":false,"error":"error: package `clap_lex v0.7.4` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0\nEither upgrade to rustc 1.74 or newer, or use\ncargo update -p [email protected] --precise ver\nwhere `ver` is the latest version of `clap_lex` supporting rustc 1.70.0\n"}}

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 7, 2024
@alamb alamb changed the title Minor: add comments explaining bad MSRV Minor: add comments explaining bad MSRV, output in json Dec 7, 2024
@github-actions github-actions bot removed the arrow Changes to the arrow crate label Dec 8, 2024
@alamb alamb closed this Dec 8, 2024
@alamb alamb reopened this Dec 8, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 8, 2024

Reopened to trigger CI to see if Alexhuszagh/rust-lexical#191 fixes #6858

@alamb alamb marked this pull request as ready for review December 9, 2024 10:40
@tustvold tustvold merged commit 565c24b into apache:main Dec 18, 2024
62 of 65 checks passed
@alamb alamb deleted the alamb/msrv_comments branch December 18, 2024 11:03
@alamb
Copy link
Contributor Author

alamb commented Dec 18, 2024

Thank you @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants