Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "max statistics size" property in WriterProperties #6884

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Dec 16, 2024

Which issue does this PR close?

Closes #2033.

Rationale for this change

The max_statistics_size writer property is never used. Start the process of removing it.

What changes are included in this PR?

Adds deprecation tags to the field and functions that modify it. Remove usages in unit tests.

Are there any user-facing changes?

No, only deprecates.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Dec 16, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @etseidl

@tustvold tustvold merged commit 123045c into apache:main Dec 17, 2024
16 checks passed
@etseidl etseidl deleted the deprecate_max_stats_size branch December 17, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet Writer Ignores "max statistics size" specification in WriterProperties
3 participants