Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Field::with_dict_is_ordered #6885

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add Field::with_dict_is_ordered #6885

merged 1 commit into from
Dec 18, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 16, 2024

Which issue does this PR close?

Rationale for this change

#6873 didn't deprecate dict_is_ordered but there is no way to set the ordered field now that Field::new_with_dict was deprecated

What changes are included in this PR?

Add Field::with_dict_id_ordered setter and docs

Are there any user-facing changes?

New API

@alamb alamb marked this pull request as ready for review December 16, 2024 20:41
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 16, 2024
@brancz
Copy link
Contributor

brancz commented Dec 17, 2024

Makes sense!

@tustvold tustvold merged commit 1079360 into apache:main Dec 18, 2024
26 checks passed
@alamb alamb deleted the alamb/create_ordered_api branch December 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @brancz @tustvold