feat: add min max aggregate support for FixedSizeBinary #7675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HawaiianSpork
approved these changes
Jun 16, 2025
alexwilcoxson-rel
force-pushed
the
min-max-fixed-binary
branch
from
334d56e to
0b4a5f1
Compare
alexwilcoxson-rel
force-pushed
the
min-max-fixed-binary
branch
from
0b4a5f1 to
0112b3d
Compare
alamb
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Thank you for this contribution @alexwilcoxson-rel and thank you for the review @HawaiianSpork 🙏
alamb
reviewed
Jun 16, 2025
| @@ -1240,6 +1250,41 @@ mod tests { | |||
| assert!(max(&a).unwrap().is_nan()); | |||
| } | |||
|
|
|||
| fn pad_inputs_and_test_fixed_size_binary( | |||
|
Thanks again @alexwilcoxson-rel and @HawaiianSpork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7674.
Rationale for this change
Adding support for these min/max functions so DataFusion can utilize them
What changes are included in this PR?
Added new min and max functions for fixed size binary and updated existing tests.
Are there any user-facing changes?
Yes new functions
min_fixed_size_binaryandmax_fixed_size_binaryadded.