Add decimal32 and decimal64 support to Parquet, JSON and CSV readers and writers #7841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
mbrobbel
approved these changes
Jul 14, 2025
| async fn test_decimal() { | ||
| // This creates a parquet file of 1 column "decimal_col" with decimal data type and precicion 9, scale 2 | ||
| async fn test_decimal32() { | ||
| // This creates a parquet file of 1 column "decimal32_col" with decimal data type and precicion 9, scale 2 |
There was a problem hiding this comment.
Suggested change
| // This creates a parquet file of 1 column "decimal32_col" with decimal data type and precicion 9, scale 2 | |
| // This creates a parquet file of 1 column "decimal32_col" with decimal data type and precision 9, scale 2 |
| } | ||
| #[tokio::test] | ||
| async fn test_decimal64() { | ||
| // This creates a parquet file of 1 column "decimal64_col" with decimal data type and precicion 9, scale 2 |
There was a problem hiding this comment.
Suggested change
| // This creates a parquet file of 1 column "decimal64_col" with decimal data type and precicion 9, scale 2 | |
| // This creates a parquet file of 1 column "decimal64_col" with decimal data type and precision 9, scale 2 |
| } | ||
| #[tokio::test] | ||
| async fn test_decimal128() { | ||
| // This creates a parquet file of 1 column "decimal128_col" with decimal data type and precicion 9, scale 2 |
There was a problem hiding this comment.
Suggested change
| // This creates a parquet file of 1 column "decimal128_col" with decimal data type and precicion 9, scale 2 | |
| // This creates a parquet file of 1 column "decimal128_col" with decimal data type and precision 9, scale 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This change adds
decimal32anddecimal64support to Parquet, JSON and CSV readers and writers. It does not change the current default behavior of the Parquet reader which (in the absence of a specification that says otherwise) will still translate the INT32 physical type with a logical DECIMAL type into adecimal128instead of adecimal32.Are these changes tested?
Yes.
Are there any user-facing changes?
The
decimal32anddecimal64types are now supported in Parquet, JSON and CSV readers and writers.