fix: incorrect assertion in BitChunks::new
#8620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 16, 2025
| /// Create a new [`BitChunks`] from a byte array, and an offset and length in bits | ||
| pub fn new(buffer: &'a [u8], offset: usize, len: usize) -> Self { | ||
| assert!(ceil(offset + len, 8) <= buffer.len() * 8); | ||
| assert!( |
There was a problem hiding this comment.
The issue is that buffer.len() is already in bytes, right? So multiplying by 8 scales it too much
Weijun-H
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
not testing the correct length
What changes are included in this PR?
remove * 8 as the length of the buffer is in bytes already
Are these changes tested?
created tests to make sure they are failing before AND created tests that make sure that ceil is used for future changes
Are there any user-facing changes?
Nope