[thrift-remodel] Add macro to reduce boilerplate necessary to implement Thrift serialization #8634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
Structures that are to be Thrift serialized as fields in another struct must implement the
WriteThriftField
trait. In most instances the implementation of that trait is trivial and adds unnecessary verbosity to the code.What changes are included in this PR?
Add a new
write_thrift_field
macro that generates this boilerplate code.Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No