Skip to content

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 16, 2025

Which issue does this PR close?

We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.

Rationale for this change

Structures that are to be Thrift serialized as fields in another struct must implement the WriteThriftField trait. In most instances the implementation of that trait is trivial and adds unnecessary verbosity to the code.

What changes are included in this PR?

Add a new write_thrift_field macro that generates this boilerplate code.

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 16, 2025
@etseidl
Copy link
Contributor Author

etseidl commented Oct 16, 2025

@mbrobbel @alamb It's not critical this make it into 57.0.0. Should I mark this draft or set the milestone to 57.1.0 so it doesn't clog the review queue?

@mbrobbel
Copy link
Member

@mbrobbel @alamb It's not critical this make it into 57.0.0. Should I mark this draft or set the milestone to 57.1.0 so it doesn't clog the review queue?

This looks like it should be quick to review. I'll take a look later today.

@mbrobbel mbrobbel added this to the 57.0.0 milestone Oct 16, 2025
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @etseidl

@etseidl
Copy link
Contributor Author

etseidl commented Oct 16, 2025

Thanks @mbrobbel...I'll stop now 😅

@etseidl etseidl merged commit f3baa80 into apache:main Oct 16, 2025
16 checks passed
@etseidl etseidl deleted the write_thrift_field branch October 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants