NodeJS

GH-45250: [JS] Fix denominator precision loss and remove unnecessary safe integer check for fractional part #2936

Sign in to view logs

Triggered via pull request January 15, 2025 01:44

yaooqinn

synchronize #45251

yaooqinn:bignum

Status Failure

Total duration 14m 12s

Artifacts –

js.yml

on: pull_request

AMD64 Debian 12 NodeJS 18

Matrix: macos

Matrix: windows

Annotations

3 errors and 33 warnings

AMD64 Debian 12 NodeJS 18

Process completed with exit code 1.

AMD64 Windows NodeJS 18

Process completed with exit code 1.

AMD64 macOS 13 NodeJS 18

Process completed with exit code 1.

AMD64 Debian 12 NodeJS 18

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L134

Move generator function 'wrap' to the outer scope

AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L172

Move async generator function 'wrap' to the outer scope

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L325

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L347

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L368

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L378

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L486

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L624

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L134

Move generator function 'wrap' to the outer scope

AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L172

Move async generator function 'wrap' to the outer scope

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L325

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L347

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L368

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L378

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L486

Unnecessarily cloning an array

AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L624

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L134

Move generator function 'wrap' to the outer scope

AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L172

Move async generator function 'wrap' to the outer scope

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L325

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L347

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L368

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L378

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L486

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L624

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L134

Move generator function 'wrap' to the outer scope

AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L172

Move async generator function 'wrap' to the outer scope

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L325

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L347

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L368

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L378

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L486

Unnecessarily cloning an array

AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L624

Unnecessarily cloning an array