Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### Rationale for this change Fixing a flaky test that is *very* difficult to reproduce. ### What changes are included in this PR? Adding an explicit call to drain the remaining batches from the parameter batch reader in the `DoPutPreparedStatementQuery` of the `MockServer` in the tests. This ensures that the gRPC connection doesn't close on us in between the client writing the schema message and writing the record batch message producing an `io.EOF` error. This is an extremely rare occurence based on goroutine scheduling due to the client and mockserver both running in the same process for the tests, in local testing i was only able to get it to happen 1 - 4 times per 5000 runs of the test. ### Are there any user-facing changes? No * Closes: #35328 Authored-by: Matt Topol <[email protected]> Signed-off-by: Matt Topol <[email protected]>
- Loading branch information