Skip to content

Commit

Permalink
minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
kszucs committed Dec 11, 2024
1 parent 3a666a5 commit 79c9b0a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
6 changes: 0 additions & 6 deletions cpp/src/arrow/compute/kernels/scalar_hash.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,7 @@
// specific language governing permissions and limitations
// under the License.

/**
* @file scalar_hash.cc
* @brief Element-wise (scalar) kernels for hashing values.
*/

#include <algorithm>
//#include <iostream>

#include "arrow/array/array_base.h"
#include "arrow/array/builder_primitive.h"
Expand Down
16 changes: 0 additions & 16 deletions cpp/src/arrow/compute/light_array_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@
namespace arrow {
namespace compute {

// Forward declaration of KeyColumnArray for convenience of creating a type alias
class KeyColumnArray;
using KeyColumnVector = std::vector<KeyColumnArray>;

/// \brief Context needed by various execution engine operations
///
/// In the execution engine this context is provided by either the node or the
Expand Down Expand Up @@ -89,7 +85,6 @@ class ARROW_EXPORT KeyColumnArray {
public:
/// \brief Create an uninitialized KeyColumnArray
KeyColumnArray() = default;

/// \brief Create a read-only view from buffers
///
/// This is a view only and does not take ownership of the buffers. The lifetime
Expand Down Expand Up @@ -226,17 +221,6 @@ class ARROW_EXPORT KeyColumnArray {
ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(
const std::shared_ptr<DataType>& type);

ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(const DataType* type);

/// \brief Create KeyColumnArray instances from an ArraySpan (nested types supported)
///
/// The caller should ensure this is only called on "key" columns. Some nested types are
/// supported up to 1 level of nesting (e.g. List<int8> but not List<List<int8>>).
/// \see ColumnMetadataFromDataType for details
ARROW_EXPORT Result<KeyColumnArray> ColumnArrayFromArraySpan(const ArraySpan& array_span,
int64_t start_row,
int64_t num_rows);

/// \brief Create KeyColumnArray from ArrayData
///
/// If `type` is a dictionary type then this will return the KeyColumnArray for
Expand Down

0 comments on commit 79c9b0a

Please sign in to comment.