Review feedback

apache · Sep 11, 2024 · 8b27962 · 8b27962
1 parent 82e1db3
commit 8b27962
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/cpp/src/parquet/arrow/arrow_schema_test.cc b/cpp/src/parquet/arrow/arrow_schema_test.cc
@@ -790,17 +790,15 @@ TEST_F(TestConvertParquetSchema, ParquetSchemaArrowExtensions) {
   }
 
   {
-    // Parquet file contains Arrow schema.
-    // A contrived example. Parquet believes both columns are JSON. Arrow believes json_1
-    // is a JSON column and json_2 is an utf8 column. json_2 should be treated as an
-    // JSON column even if arrow extensions are enabled.
+    // Parquet file contains Arrow schema. Extensions are enabled.
+    // Both json_1 and json_2 should be returned as a json() field
     ArrowReaderProperties props;
     props.set_arrow_extensions_enabled(true);
     std::shared_ptr<KeyValueMetadata> field_metadata =
         ::arrow::key_value_metadata({"foo", "bar"}, {"biz", "baz"});
     auto arrow_schema = ::arrow::schema(
         {::arrow::field("json_1", ::arrow::extension::json(), true, field_metadata),
-         ::arrow::field("json_2", ::arrow::extension::json(), true)});
+         ::arrow::field("json_2", ::arrow::extension::json(::arrow::large_utf8()), true)});
 
     std::shared_ptr<KeyValueMetadata> metadata;
     ASSERT_OK(ArrowSchemaToParquetMetadata(arrow_schema, metadata));