fix inconsistency when using noasm tag

apache · Sep 12, 2024 · 8edfb46 · 8edfb46
1 parent 589c3e4
commit 8edfb46
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/go/parquet/internal/utils/bit_packing_avx2_amd64.go b/go/parquet/internal/utils/bit_packing_avx2_amd64.go
@@ -33,12 +33,11 @@ func _unpack32_avx2(in, out unsafe.Pointer, batchSize, nbits int) (num int)
 
 func unpack32Avx2(in io.Reader, out []uint32, nbits int) int {
 	batch := len(out) / 32 * 32
-	if batch <= 0 {
+	n := batch * nbits / 8
+	if n <= 0 {
 		return 0
 	}
 
-	n := batch * nbits / 8
-
 	buffer := bufferPool.Get().(*bytes.Buffer)
 	defer bufferPool.Put(buffer)
 	buffer.Reset()

diff --git a/go/parquet/internal/utils/bit_packing_neon_arm64.go b/go/parquet/internal/utils/bit_packing_neon_arm64.go
@@ -33,12 +33,11 @@ func _unpack32_neon(in, out unsafe.Pointer, batchSize, nbits int) (num int)
 
 func unpack32NEON(in io.Reader, out []uint32, nbits int) int {
 	batch := len(out) / 32 * 32
-	if batch <= 0 {
+	n := batch * nbits / 8
+	if n <= 0 {
 		return 0
 	}
 
-	n := batch * nbits / 8
-
 	buffer := bufferPool.Get().(*bytes.Buffer)
 	defer bufferPool.Put(buffer)
 	buffer.Reset()

diff --git a/go/parquet/pqarrow/file_reader_test.go b/go/parquet/pqarrow/file_reader_test.go
@@ -405,6 +405,5 @@ func TestReadParquetFile(t *testing.T) {
 	require.NoError(t, err)
 
 	_, err = arrowRdr.ReadTable(ctx)
-
-	assert.Error(t, err)
+	assert.NoError(t, err)
 }