Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleFU committed Nov 15, 2023
1 parent 8564034 commit a93ea70
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cpp/src/arrow/dataset/file_parquet_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,10 @@ class DelayedBufferReader : public ::arrow::io::BufferReader {
std::atomic<int> read_async_count{0};
};

TEST_F(TestParquetFileFormat, MultithreadedScanUnsafe) {
TEST_F(TestParquetFileFormat, MultithreadedScanRegression) {
// GH-38438: This test is similar to MultithreadedScan, but it try to use self
// designed Executor and DelayedBufferReader to mock async execution to make
// the state machine more complex.
auto reader = MakeGeneratedRecordBatch(schema({field("utf8", utf8())}), 10000, 100);

ASSERT_OK_AND_ASSIGN(auto buffer, ParquetFormatHelper::Write(reader.get()));
Expand All @@ -878,7 +881,6 @@ TEST_F(TestParquetFileFormat, MultithreadedScanUnsafe) {
fragment_scan_options->arrow_reader_properties->set_pre_buffer(true);

options->fragment_scan_options = fragment_scan_options;
options->use_threads = true;
ScannerBuilder builder(ArithmeticDatasetFixture::schema(), fragment, options);

ASSERT_OK(builder.UseThreads(true));
Expand Down

0 comments on commit a93ea70

Please sign in to comment.