Skip to content

Commit

Permalink
MINOR: [Dev] Remove auto close link forced in PR description (#40178)
Browse files Browse the repository at this point in the history
For some reason, #14783 changed the automatic GH issue link to a "Closes" reference that will forcefully close the linked issue *even if the committer chooses not to close the issue using the merge script*.

Since the original change was done without discussion, this is a MINOR PR as well.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
  • Loading branch information
pitrou authored Feb 21, 2024
1 parent 1ffed20 commit b51c318
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/dev_pr/link.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
// Make the call to ensure issue exists before adding comment
const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
const message = "* Closes: #" + issueInfo.number
const message = "* GitHub Issue: #" + issueInfo.number
if (issueInfo) {
const body = context.payload.pull_request.body || "";
if (body.includes(message)) {
Expand Down

0 comments on commit b51c318

Please sign in to comment.