added deprecated flags to Make ::arrow::Status versions

apache · Nov 24, 2024 · b54b107 · b54b107
1 parent 18a5b80
commit b54b107
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/cpp/src/parquet/arrow/reader.h b/cpp/src/parquet/arrow/reader.h
@@ -115,12 +115,27 @@ class RowGroupReader;
 // arrays
 class PARQUET_EXPORT FileReader {
  public:
+  // Factory function to create a FileReader from a ParquetFileReader and properties.
+  // \deprecated Deprecated in 19.0.0. Use arrow::Result version instead.
+  ARROW_DEPRECATED("Deprecated in 19.0.0. Use arrow::Result version instead.")
+  static ::arrow::Status Make(
+      ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader> reader,
+      const ArrowReaderProperties& properties, std::unique_ptr<FileReader>* out);
+
   /// Factory function to create a FileReader from a ParquetFileReader and properties
   static ::arrow::Result<std::unique_ptr<FileReader>> Make(
       ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader> reader,
       const ArrowReaderProperties& properties, std::unique_ptr<FileReader>* out);
 
-  /// Factory function to create a FileReader from a ParquetFileReader
+  // Factory function to create a FileReader from a ParquetFileReader.
+  // \deprecated Deprecated in 19.0.0. Use arrow::Result version instead.
+  ARROW_DEPRECATED("Deprecated in 19.0.0. Use arrow::Result version instead.")
+  static ::arrow::Result<std::unique_ptr<FileReader>> Make(
+      ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader> reader,
+      std::unique_ptr<FileReader>* out);
+
+  // Factory function to create a FileReader from a ParquetFileReader.
+  // Returns an arrow::Result containing a unique pointer to the FileReader.
   static ::arrow::Result<std::unique_ptr<FileReader>> Make(
       ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader> reader,
       std::unique_ptr<FileReader>* out);