Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Adding Spotless to Memory module #40829

Closed
Tracked by #40757
vibhatha opened this issue Mar 27, 2024 · 1 comment
Closed
Tracked by #40757

[Java] Adding Spotless to Memory module #40829

vibhatha opened this issue Mar 27, 2024 · 1 comment
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Mar 27, 2024 •
edited
Loading

Describe the enhancement requested

The main issue discussing the inclusion of Spotless plugin is discussed here.

Component(s)

Java
@vibhatha vibhatha mentioned this issue Mar 27, 2024
Closed
15 tasks
laurentgo added a commit to laurentgo/arrow that referenced this issue Jun 10, 2024
@laurentgo
apacheGH-40829: [Java] Adding Spotless to Memory modules
e249dd0 
Rationale for this change
=========================

Applying Java code style and formatting options to Memory modules.
- [x] memory-core
- [x] memory-netty
- [x] memory-netty-buffer-patch
- [x] memory-unsafe

What changes are included in this PR?
=====================================

Java code formatting via spotless plugin has been enabled.

Checkstyle configuration has been changed to remove the 120 line character
limit as g-j-f does not wrap long strings

Are these changes tested?
=========================

Yes, but doesn't involve test cases, the plugin itself corrects.

Are there any user-facing changes?
==================================

No
@github-actions github-actions bot mentioned this issue Jun 10, 2024
Merged
4 tasks
laurentgo added a commit to laurentgo/arrow that referenced this issue Jun 10, 2024
@laurentgo
apacheGH-40829: [Java] Adding Spotless to Tools module
64b2cf5 
Rationale for this change
=========================

Applying Java code style and formatting options to Tools module.

What changes are included in this PR?
=====================================

Java code formatting via spotless plugin has been enabled.

Are these changes tested?
=========================

Yes, but doesn't involve test cases, the plugin itself corrects.

Are there any user-facing changes?
==================================

No
lidavidm pushed a commit that referenced this issue Jun 11, 2024
@laurentgo
GH-40829: [Java] Adding Spotless to Memory modules (#42056)
ee62d97 
### Rationale for this change

Applying Java code style and formatting options to Memory modules.
- [x] memory-core
- [x] memory-netty
- [x] memory-netty-buffer-patch
- [x] memory-unsafe

### What changes are included in this PR?

Java code formatting via spotless plugin has been enabled.

Checkstyle configuration has been changed to remove the 120 line character limit as g-j-f does not wrap long strings

### Are these changes tested?

Yes, but doesn't involve test cases, the plugin itself corrects.

### Are there any user-facing changes?

No

* GitHub Issue: #40829

Authored-by: Laurent Goujon <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 17.0.0 milestone Jun 11, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 42056
#42056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@lidavidm @vibhatha