GH-40829: [Java] Adding Spotless to Memory modules #42056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale for this change ========================= Applying Java code style and formatting options to Memory modules. - [x] memory-core - [x] memory-netty - [x] memory-netty-buffer-patch - [x] memory-unsafe What changes are included in this PR? ===================================== Java code formatting via spotless plugin has been enabled. Checkstyle configuration has been changed to remove the 120 line character limit as g-j-f does not wrap long strings Are these changes tested? ========================= Yes, but doesn't involve test cases, the plugin itself corrects. Are there any user-facing changes? ================================== No
|
|
vibhatha
reviewed
Jun 10, 2024
|
@github-actions crossbow submit -g java |
github-actions
bot
added
awaiting committer review
|
Revision: e249dd0 Submitted crossbow builds: ursacomputing/crossbow @ actions-fb565b2f51
|
vibhatha
approved these changes
Jun 11, 2024
lidavidm
approved these changes
Jun 11, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ee62d97. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Applying Java code style and formatting options to Memory modules.
What changes are included in this PR?
Java code formatting via spotless plugin has been enabled.
Checkstyle configuration has been changed to remove the 120 line character limit as g-j-f does not wrap long strings
Are these changes tested?
Yes, but doesn't involve test cases, the plugin itself corrects.
Are there any user-facing changes?
No