-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Update Unit Tests to use org.junit.jupiter.api
#41680
Comments
@vibhatha I have verified the |
@llama90 You are correct, we don't need to work on |
@vibhatha I think I will start after merging the spotless changes for each module to avoid conflicts. |
@llama90 that's good idea. |
@vibhatha Additionally, the Please cross-check when you have free time. Thank you. |
@llama90 Done! Thanks for looking into this. |
@vibhatha I attached the remaining issues for updating the contents. |
@llama90 Thank you for updating it here. I will make sure to update the list. I am out today, will be a bit slow on reviews. |
No problem! Have a nice day. |
### Rationale for this change ### What changes are included in this PR? I followed the format for the other sub-issues of GH-41680 (flight, etc.) ### Are these changes tested? Yes. This is actually migration of tests from JUnit 4 to JUnit 5. They pass. ### Are there any user-facing changes? * GitHub Issue: #41680 * GitHub Issue: #42165 Authored-by: Ed and Gravy <[email protected]> Signed-off-by: David Li <[email protected]>
@vibhatha after this is done, we also need to remove all JUnit 4 dependencies and preferably exclude them so we don't accidentally re-take a dependency on JUnit 4 |
@lidavidm I will work on that. Definitely. |
Finally, we've completed this issue. Thank you for your effort, @lidavidm and @vibhatha. It was interesting and helped me learn a lot. If there are any other issues I can help solve, please let me know. I'm not yet familiar with the entire codebase in Java, but I'm getting the hang of it. Thank you! |
Describe the enhancement requested
At the moment, test cases are using an older API version of Junit, and this should be upgraded to use the latest API.
It would be best if we can do this module per module by creating an issue per module and list it here.
Component(s)
Java
The text was updated successfully, but these errors were encountered: