Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Update Unit Tests for Algorithm Module #42025

Closed
Tracked by #41680
llama90 opened this issue Jun 7, 2024 · 3 comments
Closed
Tracked by #41680

[Java] Update Unit Tests for Algorithm Module #42025

llama90 opened this issue Jun 7, 2024 · 3 comments
Assignees
@llama90
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@llama90
Copy link
Contributor

llama90 commented Jun 7, 2024

Describe the enhancement requested

This is a sub-issue of the issue below.

The unit tests should use the org.junit.jupiter.api package. This issue deals with the algorithm module.

Component(s)

Java
@llama90
Copy link
Contributor Author

llama90 commented Jun 7, 2024

@vibhatha I’ll handle this issue the same way as PR #42019.

@vibhatha
Copy link
Collaborator

vibhatha commented Jun 7, 2024

Great. Looking forward to it.

@vibhatha vibhatha mentioned this issue Jun 7, 2024
Closed
12 tasks
@github-actions github-actions bot mentioned this issue Jun 7, 2024
Merged
7 tasks
lidavidm pushed a commit that referenced this issue Jun 12, 2024
@llama90
GH-42025: [Java] Update Unit Tests for Algorithm Module (#42029)
23e1f4c 
### Rationale for this change

Update package from JUnit 4(`org.junit`) to JUnit 5(`org.junit.jupiter`).

### What changes are included in this PR?

- [x] Replacing `org.junit` and `junit.framework.TestCase` with `org.junit.jupiter.api`.
- [x] Updating `Assertions.assertXXX` to `assertXXX` using static imports.
- [x] Updating annotations such as `@ Before`, `@ After`.
  - `@ Before` -> `@ BeforeEach`
  - `@ After` -> `@ AfterEach`
  - `@ Test` -> `@ Test` with `org.junit.jupiter`
- [x] Updating `Parameterized` test
- [x] Doing self review round 1
- [x] Resolving conflcit
- [x] Doing self review rount 2

### Are these changes tested?

Yes, existing tests have passed.

### Are there any user-facing changes?

No.

* GitHub Issue: #42025

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 17.0.0 milestone Jun 12, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 42029
#42029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llama90 llama90

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@lidavidm @llama90 @vibhatha