Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Cleanup spotless and checkstyle configuration #42121

Closed
laurentgo opened this issue Jun 12, 2024 · 2 comments · Fixed by #43019
Closed

[Java] Cleanup spotless and checkstyle configuration #42121

laurentgo opened this issue Jun 12, 2024 · 2 comments · Fixed by #43019
Assignees
@laurentgo
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@laurentgo
Copy link
Contributor

Describe the enhancement requested

Once all modules have been configured with spotless, the global spotless configuration should be changed to enable java formatting on all files and the individual configurations should be removed so that any new module would follow the new code style standard.

Checkstyle global configuration should also be changed to use the new configuration which does not conflict with spotless

Finally (nice to have) it may be good to add all the reformatting commits to a .git-blame-ignore-revs file so that git blame view on Github would ignore those commits since the changes are mostly automatic and cosmetic.

Component(s)

Java
@laurentgo laurentgo mentioned this issue Jun 12, 2024
Closed
15 tasks
@vibhatha
Copy link
Collaborator

@laurentgo I was planning to do it in #40826 as we don't need formatting for auto generated content in the format module. But if you prefer, you could choose that issue and finalize it or you could use this.

laurentgo added a commit to laurentgo/arrow that referenced this issue Jun 24, 2024
@laurentgo
apacheGH-42121: [Java] Cleanup spotless plugin configuration
da274ac 
As all modules have been migrated over to spotless, remove per-module
configuration and enable java formatting at the root level.

Exclude format module from java formatting but still enable license
formatting for this module as well.

Fixes apache#42121 apache#40826
@laurentgo laurentgo mentioned this issue Jun 24, 2024
Merged
@lidavidm lidavidm added this to the 17.0.0 milestone Jun 25, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 43019
#43019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

Successfully merging a pull request may close this issue.

GH-42121: [Java] Cleanup spotless plugin configuration laurentgo/arrow
3 participants
@lidavidm @laurentgo @vibhatha