GH-42121: [Java] Cleanup spotless plugin configuration #43019
Conversation
As all modules have been migrated over to spotless, remove per-module configuration and enable java formatting at the root level. Exclude format module from java formatting but still enable license formatting for this module as well. Fixes apache#42121 apache#40826
|
|
github-actions
bot
added
Component: Java
Component: Documentation
awaiting review
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // automatically generated by the FlatBuffers compiler, do not modify | ||
|
|
There was a problem hiding this comment.
This shouldn't be formatted at all, right?
There was a problem hiding this comment.
The license header is added manually to the generated files. I thought it should be consistent with the other java files as well, which is why I changed those and updated the README.md section regarding the format module but the java formatting has been disabled.
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit -g java |
github-actions
bot
added
awaiting merge
|
Revision: a6ff51f Submitted crossbow builds: ursacomputing/crossbow @ actions-8a68e8380e
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3e7ae53. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
What changes are included in this PR?
As all modules have been migrated over to spotless, remove per-module configuration and enable java formatting at the root level.
Exclude format module from java formatting but still enable license formatting for this module as well.
Are these changes tested?
Through CI/CD
Are there any user-facing changes?
No
Fixes #42121 #40826