Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Adding Spotless to Format module #40826

Closed
Tracked by #40757
vibhatha opened this issue Mar 27, 2024 · 3 comments
Closed
Tracked by #40757

[Java] Adding Spotless to Format module #40826

vibhatha opened this issue Mar 27, 2024 · 3 comments
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Mar 27, 2024 •
edited
Loading

Describe the enhancement requested

The main issue discussing the inclusion of Spotless plugin is discussed here.

Component(s)

Java
@vibhatha vibhatha mentioned this issue Mar 27, 2024
Closed
15 tasks
@vibhatha vibhatha self-assigned this Jun 10, 2024
@vibhatha
Copy link
Collaborator Author

Since this content is autogenerated we don't need to format this either.
But in a follow up PR, we should add a config to disable running the formatter in this module. So keeping this until we make a final PR to clean things up.

@laurentgo
Copy link
Contributor

This content may have been autogenerated but it is not the case anymore (it also doesn't have the @Generated annotation). I'm not sure we need to carve an exception except if we would want to diff with a new version of the generated code in the future? (but seems unlikely)

@vibhatha vibhatha mentioned this issue Jun 18, 2024
Closed
laurentgo added a commit to laurentgo/arrow that referenced this issue Jun 24, 2024
@laurentgo
apacheGH-42121: [Java] Cleanup spotless plugin configuration
da274ac 
As all modules have been migrated over to spotless, remove per-module
configuration and enable java formatting at the root level.

Exclude format module from java formatting but still enable license
formatting for this module as well.

Fixes apache#42121 apache#40826
@laurentgo laurentgo mentioned this issue Jun 24, 2024
Merged
lidavidm pushed a commit that referenced this issue Jun 25, 2024
@laurentgo
GH-42121: [Java] Cleanup spotless plugin configuration (#43019)
3e7ae53 
### What changes are included in this PR?

As all modules have been migrated over to spotless, remove per-module configuration and enable java formatting at the root level.

Exclude format module from java formatting but still enable license formatting for this module as well.

### Are these changes tested?

Through CI/CD

### Are there any user-facing changes?

No

Fixes #42121 #40826
* GitHub Issue: #42121

Authored-by: Laurent Goujon <[email protected]>
Signed-off-by: David Li <[email protected]>
@laurentgo
Copy link
Contributor

This was addressed by #43019. Maybe this issue can be closed?

@lidavidm lidavidm added this to the 17.0.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@lidavidm @laurentgo @vibhatha