Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Update bundled Abseil and gRPC #45063

Open
raulcd opened this issue Dec 18, 2024 · 4 comments
Open

[C++] Update bundled Abseil and gRPC #45063

raulcd opened this issue Dec 18, 2024 · 4 comments

Comments

@raulcd
Copy link
Member

raulcd commented Dec 18, 2024

Describe the enhancement requested

We are currently using an Abseil version from 2021:

ARROW_ABSL_BUILD_VERSION=20211102.0
ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4

And a gRPC from 2022 (https://github.com/grpc/grpc/releases/tag/v1.46.2):

ARROW_GRPC_BUILD_VERSION=v1.46.3
ARROW_GRPC_BUILD_SHA256_CHECKSUM=d6cbf22cb5007af71b61c6be316a79397469c58c82a942552a62e708bce60964

We should update those dependencies.

Component(s)

C++

@assignUser
Copy link
Member

I have a PR I dropped to do this, the target tree changed which makes this annoying IIRC #37066

@assignUser
Copy link
Member

assignUser commented Dec 18, 2024

Hm I guess I never pushed the changes, as the PR is just the changed versions.txt, I remember trying to move over absl to fetch content but that also meant moving over the dependencies/dependents and grew out of hand quickly

@raulcd
Copy link
Member Author

raulcd commented Dec 18, 2024

Do you recall why did you drop the issue? I can't see logs for what was going on that PR. I am trying to figure out the current failure which seems to be a common one as per #45064 (comment) , basically solving:

/build/cpp/grpc_ep-prefix/src/grpc_ep/include/grpcpp/impl/codegen/config_protobuf.h:81:10: fatal error: absl/status/status.h: No such file or directory
   81 | #include "absl/status/status.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~

@assignUser
Copy link
Member

assignUser commented Dec 18, 2024

Because of external project we have to replicate the abseil target tree, there is a bash oneliner commented in thirdparty cmake that explains it. And I think there were changes there that require it to be regenerated but it has been a long time.

@kou kou changed the title [C++] Update bundled ABSL and GRPC [C++] Update bundled Abseil and gRPC Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants