Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45063: [C++] Update bundled Abseil and gRPC #45064

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 18, 2024

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link

⚠️ GitHub issue #45063 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Dec 18, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 18, 2024
@raulcd
Copy link
Member Author

raulcd commented Dec 18, 2024

I seem to be facing the same issue as:
grpc/grpc#33887

-- stderr output is:
In file included from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/config_protobuf.h:22,
                 from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/config.h:24,
                 from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/csharp_generator.h:22,
                 from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/csharp_generator.cc:19:
/build/cpp/grpc_ep-prefix/src/grpc_ep/include/grpcpp/impl/codegen/config_protobuf.h:81:10: fatal error: absl/status/status.h: No such file or directory
   81 | #include "absl/status/status.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~

Copy link

Revision: bc93d48

Submitted crossbow builds: ursacomputing/crossbow @ actions-56b96cfd95

Task Status
test-ubuntu-20.04-cpp-bundled GitHub Actions

Comment on lines +3029 to +3031
absl::check
absl::log
absl::vlog_is_on
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those three weren't picked by the command but were necessary to build

@@ -3948,11 +4382,13 @@ macro(build_grpc)
GRPC_C_FLAGS
" -Wno-attributes"
" -Wno-format-security"
" -Wno-return-type"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add those to avoid a bunch of those:

/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h: In member function 'grpc_core::Poll<typename grpc_core::promise_detail::OncePromiseFactory<void, F>::Promise::Result> grpc_core::Party::PromiseParticipantImpl<SuppliedFactory>::PollCompletion() [with SuppliedFactory = grpc_core::ForwardCall(grpc_core::CallHandler, grpc_core::CallInitiator, absl::lts_20240722::AnyInvocable<void(grpc_metadata_batch&)>)::<lambda()> mutable::<lambda(std::optional<std::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter> >)> mutable::<lambda()> mutable::<lambda(grpc_core::MessageHandle)> mutable::<lambda()>]':
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h:284:5: warning: control reaches end of non-void function [-Wreturn-type]
  284 |     }
      |     ^

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 18, 2024
@kou kou changed the title GH-45063: [C++] Update Bundled ABSL and GRPC GH-45063: [C++] Update bundled Abseil and gRPC Dec 19, 2024
@kou
Copy link
Member

kou commented Dec 19, 2024

Abseil: Let's migrate to FetchContent from ExternalProject. We don't want to maintain Abseil dependencies manually...

@raulcd
Copy link
Member Author

raulcd commented Dec 19, 2024

Abseil: Let's migrate to FetchContent from ExternalProject. We don't want to maintain Abseil dependencies manually...

Sounds good to me, probably worth waiting to upgrade CMake then as there were a lot of additions / improvements around FetchContent around CMake 3.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants