-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45063: [C++] Update bundled Abseil and gRPC #45064
base: main
Are you sure you want to change the base?
Conversation
|
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled |
I seem to be facing the same issue as:
|
Revision: bc93d48 Submitted crossbow builds: ursacomputing/crossbow @ actions-56b96cfd95
|
absl::check | ||
absl::log | ||
absl::vlog_is_on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those three weren't picked by the command but were necessary to build
@@ -3948,11 +4382,13 @@ macro(build_grpc) | |||
GRPC_C_FLAGS | |||
" -Wno-attributes" | |||
" -Wno-format-security" | |||
" -Wno-return-type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add those to avoid a bunch of those:
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h: In member function 'grpc_core::Poll<typename grpc_core::promise_detail::OncePromiseFactory<void, F>::Promise::Result> grpc_core::Party::PromiseParticipantImpl<SuppliedFactory>::PollCompletion() [with SuppliedFactory = grpc_core::ForwardCall(grpc_core::CallHandler, grpc_core::CallInitiator, absl::lts_20240722::AnyInvocable<void(grpc_metadata_batch&)>)::<lambda()> mutable::<lambda(std::optional<std::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter> >)> mutable::<lambda()> mutable::<lambda(grpc_core::MessageHandle)> mutable::<lambda()>]':
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h:284:5: warning: control reaches end of non-void function [-Wreturn-type]
284 | }
| ^
Abseil: Let's migrate to FetchContent from ExternalProject. We don't want to maintain Abseil dependencies manually... |
Sounds good to me, probably worth waiting to upgrade CMake then as there were a lot of additions / improvements around FetchContent around CMake 3.24. |
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?