Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35089: [CI][C++][Flight] Test failures in macos release verification nightlies #35090

Merged
merged 5 commits into from
Apr 16, 2023
Merged

GH-35089: [CI][C++][Flight] Test failures in macos release verification nightlies #35090

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1036429
GH-35089: [CI][C++][Flight] Test failures in macos release verificati…
zeroshade Apr 12, 2023
21039ff
arm timeout test
zeroshade Apr 12, 2023
3ab5a0f
pr feedback
zeroshade Apr 13, 2023
381a57e
clang format
zeroshade Apr 13, 2023
4ef0c66
pin v1.50.1 grpc-cpp for conda
zeroshade Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/flight_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ TEST_F(TestFlightClient, TimeoutFires) {
Status status = client->GetFlightInfo(options, FlightDescriptor{}).status();
auto end = std::chrono::system_clock::now();
#ifdef ARROW_WITH_TIMING_TESTS
EXPECT_LE(end - start, std::chrono::milliseconds{400});
EXPECT_LE(end - start, std::chrono::milliseconds{1200});
#else
ARROW_UNUSED(end - start);
#endif
Expand Down
6 changes: 5 additions & 1 deletion cpp/src/arrow/flight/test_definitions.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ void ConnectivityTest::TestBrokenConnection() {
ASSERT_OK(server->Shutdown());
ASSERT_OK(server->Wait());

ASSERT_RAISES(IOError, client->GetFlightInfo(FlightDescriptor::Command("")));
auto status = client->GetFlightInfo(FlightDescriptor::Command(""));
ASSERT_NOT_OK(status);
ASSERT_THAT(
status.status().code(),
::testing::AnyOf(::arrow::StatusCode::IOError, ::arrow::StatusCode::UnknownError));
}

//------------------------------------------------------------
Expand Down