GH-35243: [C#] Implement MapType #35263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
@Platob do you plan to resolve the outstanding conflicts and submit this? I would really appreciate this feature! |
|
@Platob I've taken your branch, merged the latest changes from main and added support for Map in the C API. I'm currently working on adding a few more tests as well as Archery support. Would you like to pull the changes from my branch when I'm done or should I submit a separate PR? |
|
Okay, I'm done with my changes and I pushed them to https://github.com/CurtHagenlocher/arrow/tree/Map. |
|
Damn sorry forgot I still had this pending, thank you @CurtHagenlocher, I did a version where we would need more primary control to scale up on more complex structures, I'm using a version #35299 |
westonpace
requested changes
Sep 27, 2023
There was a problem hiding this comment.
I reviewed #37885 which (if I understand correctly) includes these changes and things look pretty good. Sorry that the review was so late. Please re-request review if we want to return to this PR for some reason.
lidavidm
pushed a commit
that referenced
this pull request
Oct 5, 2023
### What changes are included in this PR? This change includes the original work by `@ Platob` from #35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes #35243 * Closes: #35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
|
Going to close this since the other PR was merged, but if you want to revisit this please feel free to reopen/file a new issue. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new MapType with array
Tested with IPC tests