-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37359: [C#] Add ToList() to Decimal128Array and Decimal256Array #37383
Conversation
|
@DanTm99 I'm curious whether you find useful to option to specify includeNulls=false. I recognize that it already exists for PrimitiveArray and think that API consistency is a valuable property, but at the same time I wonder about the kind of scenarios where this would be used. If Decimal128Array and Decimal256Array were to implement IReadOnlyList<decimal?> and ICollection<decimal?> -- allowing efficient use of LINQ ToList() -- would that meet your use case? |
@CurtHagenlocher yes, the use case I had for this would even be met by The reason I just added these However, implementing |
@westonpace @CurtHagenlocher Conflict resolved. Ready to review. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d357d2d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…ray (apache#37383) Add `ToList()` methods to `Decimal128Array` and `Decimal256Array`. * Closes: apache#37359 Authored-by: Danyaal Khan <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Add
ToList()
methods toDecimal128Array
andDecimal256Array
.