GH-37861: [C#] Fix StringArray.GetString returning null instead of empty #37862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
westonpace
requested changes
Sep 25, 2023
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ded3295. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
… of empty (apache#37862) ### Rationale for this change Fixes apache#37861. ### What changes are included in this PR? Add `BinaryArray.GetBytes(int, out bool)` overload that enables `StringArray.GetString` to reliably determine if the value is null or empty without needing an additional call to `IsNull`. ### Are these changes tested? Added a test for `StringArray.GetString` (which didn't appear to have any existing tests). Two of the cases fail without this change. I also updated the tests that call `BinaryArray.GetBytes` to use the new overload instead of a separate call to `IsNull` as extra validation. ### Are there any user-facing changes? New public overload to an existing API. * Closes: apache#37861
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
… of empty (apache#37862) ### Rationale for this change Fixes apache#37861. ### What changes are included in this PR? Add `BinaryArray.GetBytes(int, out bool)` overload that enables `StringArray.GetString` to reliably determine if the value is null or empty without needing an additional call to `IsNull`. ### Are these changes tested? Added a test for `StringArray.GetString` (which didn't appear to have any existing tests). Two of the cases fail without this change. I also updated the tests that call `BinaryArray.GetBytes` to use the new overload instead of a separate call to `IsNull` as extra validation. ### Are there any user-facing changes? New public overload to an existing API. * Closes: apache#37861
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… of empty (apache#37862) ### Rationale for this change Fixes apache#37861. ### What changes are included in this PR? Add `BinaryArray.GetBytes(int, out bool)` overload that enables `StringArray.GetString` to reliably determine if the value is null or empty without needing an additional call to `IsNull`. ### Are these changes tested? Added a test for `StringArray.GetString` (which didn't appear to have any existing tests). Two of the cases fail without this change. I also updated the tests that call `BinaryArray.GetBytes` to use the new overload instead of a separate call to `IsNull` as extra validation. ### Are there any user-facing changes? New public overload to an existing API. * Closes: apache#37861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #37861.
What changes are included in this PR?
Add
BinaryArray.GetBytes(int, out bool)overload that enablesStringArray.GetStringto reliably determine if the value is null or empty without needing an additional call toIsNull.Are these changes tested?
Added a test for
StringArray.GetString(which didn't appear to have any existing tests). Two of the cases fail without this change. I also updated the tests that callBinaryArray.GetBytesto use the new overload instead of a separate call toIsNullas extra validation.Are there any user-facing changes?
New public overload to an existing API.