GH-38011: [C++][Dataset] Change force close to tend to close on write #38030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bkietz
approved these changes
Oct 5, 2023
github-actions
bot
added
awaiting merge
kou
changed the title
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 050ccee. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
… write (apache#38030) ### Rationale for this change `CloseLargestFile()` will failed to close when non of the file has written any rows. ### What changes are included in this PR? Change `CloseLargestFile()` to `TryCloseLargestFile()`, and not throw error when it cannot find a file that haven't write any rows. ### Are these changes tested? no ### Are there any user-facing changes? bugfix * Closes: apache#38011 Authored-by: mwish <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
… write (apache#38030) ### Rationale for this change `CloseLargestFile()` will failed to close when non of the file has written any rows. ### What changes are included in this PR? Change `CloseLargestFile()` to `TryCloseLargestFile()`, and not throw error when it cannot find a file that haven't write any rows. ### Are these changes tested? no ### Are there any user-facing changes? bugfix * Closes: apache#38011 Authored-by: mwish <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… write (apache#38030) ### Rationale for this change `CloseLargestFile()` will failed to close when non of the file has written any rows. ### What changes are included in this PR? Change `CloseLargestFile()` to `TryCloseLargestFile()`, and not throw error when it cannot find a file that haven't write any rows. ### Are these changes tested? no ### Are there any user-facing changes? bugfix * Closes: apache#38011 Authored-by: mwish <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CloseLargestFile()will failed to close when non of the file has written any rows.What changes are included in this PR?
Change
CloseLargestFile()toTryCloseLargestFile(), and not throw error when it cannot find a file that haven't write any rows.Are these changes tested?
no
Are there any user-facing changes?
bugfix