GH-37650: [Python] Check filter inputs in FilterMetaFunction #38075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Python
awaiting review
|
@github-actions autotune |
pitrou
requested changes
Oct 9, 2023
cpp/src/arrow/compute/kernels/vector_selection_filter_internal.cc
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting committer review
pitrou
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
+1, thank you @p-a-a-a-trick . I fixed the C++ formatting and improved the test slightly.
|
CI failures are unrelated. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 11d5ab6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#38075) ### Rationale for this change Prevent a segfault upon passing a non-(chunked_)array object into `Table.filter`. See apache#37650. ### What changes are included in this PR? 1. Check filter Datum kind to make sure that it is an array or a chunked array 2. test that attempting to filter a table with another table raises a not implemented error ### Are these changes tested? In PyArrow, yes ### Are there any user-facing changes? Raises an error if a non-array or non-chunked_array object is passed into `Table.filter` * Closes: apache#37650 Lead-authored-by: Patrick Clarke <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38075) ### Rationale for this change Prevent a segfault upon passing a non-(chunked_)array object into `Table.filter`. See apache#37650. ### What changes are included in this PR? 1. Check filter Datum kind to make sure that it is an array or a chunked array 2. test that attempting to filter a table with another table raises a not implemented error ### Are these changes tested? In PyArrow, yes ### Are there any user-facing changes? Raises an error if a non-array or non-chunked_array object is passed into `Table.filter` * Closes: apache#37650 Lead-authored-by: Patrick Clarke <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38075) ### Rationale for this change Prevent a segfault upon passing a non-(chunked_)array object into `Table.filter`. See apache#37650. ### What changes are included in this PR? 1. Check filter Datum kind to make sure that it is an array or a chunked array 2. test that attempting to filter a table with another table raises a not implemented error ### Are these changes tested? In PyArrow, yes ### Are there any user-facing changes? Raises an error if a non-array or non-chunked_array object is passed into `Table.filter` * Closes: apache#37650 Lead-authored-by: Patrick Clarke <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prevent a segfault upon passing a non-(chunked_)array object into
Table.filter. See #37650.What changes are included in this PR?
Are these changes tested?
In PyArrow, yes
Are there any user-facing changes?
Raises an error if a non-array or non-chunked_array object is passed into
Table.filter