GH-38090: [C++][Emscripten] acero/hash_join: Suppress shorten-64-to-32 warnings #38093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4-to-32 warnings We need explicit cast to use `int64_t` for `size_t` on Emscripten. Explicit casts.
github-actions
bot
added
Component: C++
awaiting committer review
westonpace
approved these changes
Oct 9, 2023
github-actions
bot
added
awaiting merge
felipecrv
approved these changes
Oct 11, 2023
felipecrv
reviewed
Oct 11, 2023
| @@ -478,9 +478,10 @@ class HashJoinBasicImpl : public HashJoinImpl { | |||
| ARROW_DCHECK(batch[i].is_scalar()); | |||
| if (!batch[i].scalar_as<arrow::internal::PrimitiveScalarBase>().is_valid) { | |||
| if (nn_bit_vector_all_nulls->empty()) { | |||
| nn_bit_vector_all_nulls->resize(bit_util::BytesForBits(batch.length)); | |||
| nn_bit_vector_all_nulls->resize( | |||
| static_cast<size_t>(bit_util::BytesForBits(batch.length))); | |||
There was a problem hiding this comment.
We should consider making BytesForBits return size_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need explicit cast to use
int64_tforsize_ton Emscripten.What changes are included in this PR?
Explicit casts.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.