GH-38090: [C++][Emscripten][Parquet] Suppress shorten-64-to-32 warnings #38129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warnings We need explicit cast to use `int64_t` for `size_t` on Emscripten. Explicit casts.
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
wgtmac
approved these changes
Oct 8, 2023
mapleFU
approved these changes
Oct 8, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 60916fe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…warnings (apache#38129) ### Rationale for this change We need explicit cast to use `int64_t` for `size_t` on Emscripten. ### What changes are included in this PR? Explicit casts. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38090 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…warnings (apache#38129) ### Rationale for this change We need explicit cast to use `int64_t` for `size_t` on Emscripten. ### What changes are included in this PR? Explicit casts. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38090 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…warnings (apache#38129) ### Rationale for this change We need explicit cast to use `int64_t` for `size_t` on Emscripten. ### What changes are included in this PR? Explicit casts. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38090 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need explicit cast to use
int64_tforsize_ton Emscripten.What changes are included in this PR?
Explicit casts.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.