GH-38077: [C++] Output bundled GoogleTest to ${BUILD_DIR}/${CONFIG} #38132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit java-jars |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Oct 8, 2023
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Oct 8, 2023
|
@github-actions crossbow submit java-jars |
kou
changed the title
|
Revision: 859ecc9 Submitted crossbow builds: ursacomputing/crossbow @ actions-97d56254dd
|
To find bundled GoogleTest DLLs, we need to set PATH or output GoogleTest DLLs to the same directory of test executables. The latter is used.
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Oct 9, 2023
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Oct 9, 2023
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Oct 9, 2023
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d602d40. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…FIG} (apache#38132) ### Rationale for this change To find DLLs on Windows, we need to add a directory of these DLLs to PATH or put these DLLs to the same directory of the target .exe. ### What changes are included in this PR? Output bundled GoogleTest's DLLs to the same directory of the test .exe. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38077 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…FIG} (apache#38132) ### Rationale for this change To find DLLs on Windows, we need to add a directory of these DLLs to PATH or put these DLLs to the same directory of the target .exe. ### What changes are included in this PR? Output bundled GoogleTest's DLLs to the same directory of the test .exe. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38077 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…FIG} (apache#38132) ### Rationale for this change To find DLLs on Windows, we need to add a directory of these DLLs to PATH or put these DLLs to the same directory of the target .exe. ### What changes are included in this PR? Output bundled GoogleTest's DLLs to the same directory of the test .exe. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38077 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
To find DLLs on Windows, we need to add a directory of these DLLs to PATH or put these DLLs to the same directory of the target .exe.
What changes are included in this PR?
Output bundled GoogleTest's DLLs to the same directory of the test .exe.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.