GH-37952: [C++] Make unique->shared explicit to fix build failure on at least one compiler #38136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse153 |
|
Revision: 3e3333d Submitted crossbow builds: ursacomputing/crossbow @ actions-94824ae4b6
|
kou
reviewed
Oct 8, 2023
Comment on lines
465
to
467
| return arrow_reader; | ||
|
|
||
| std::shared_ptr<parquet::arrow::FileReader> file_reader_shared(arrow_reader.release()); | ||
| return file_reader_shared; |
There was a problem hiding this comment.
Does return std::move(arrow_reader) work?
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse153 |
|
Revision: 465b5af Submitted crossbow builds: ursacomputing/crossbow @ actions-ecf7a4c44e
|
mapleFU
approved these changes
Oct 9, 2023
|
@github-actions crossbow submit -g nightly |
pitrou
approved these changes
Oct 9, 2023
|
Revision: 465b5af Submitted crossbow builds: ursacomputing/crossbow @ actions-eefdca42ba
|
|
Ok, none of the CI failures is related. Thank you @paleolimbot ! |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ad26f3f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…re on at least one compiler (apache#38136) ### Rationale for this change The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days. ### What changes are included in this PR? Made the unique->shared conversion explicit. ### Are these changes tested? Yes (by existing tests) ### Are there any user-facing changes? No. * Closes: apache#37952 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…re on at least one compiler (apache#38136) ### Rationale for this change The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days. ### What changes are included in this PR? Made the unique->shared conversion explicit. ### Are these changes tested? Yes (by existing tests) ### Are there any user-facing changes? No. * Closes: apache#37952 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…re on at least one compiler (apache#38136) ### Rationale for this change The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days. ### What changes are included in this PR? Made the unique->shared conversion explicit. ### Are these changes tested? Yes (by existing tests) ### Are there any user-facing changes? No. * Closes: apache#37952 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The test-r-rstudio-r-base-4.1-opensuse153 nightly has been failing with a compile error for many days.
What changes are included in this PR?
Made the unique->shared conversion explicit.
Are these changes tested?
Yes (by existing tests)
Are there any user-facing changes?
No.