-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38402: [CI][Integration] Provide wrapper scripts for integration testing #38403
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,11 +20,25 @@ | |
set -ex | ||
|
||
arrow_dir=${1} | ||
build_dir=${2} | ||
|
||
gold_dir=$arrow_dir/testing/data/arrow-ipc-stream/integration | ||
|
||
: ${ARROW_INTEGRATION_CPP:=ON} | ||
: ${ARROW_INTEGRATION_CSHARP:=ON} | ||
: ${ARROW_INTEGRATION_GO:=ON} | ||
: ${ARROW_INTEGRATION_JAVA:=ON} | ||
: ${ARROW_INTEGRATION_JS:=ON} | ||
|
||
pip install -e $arrow_dir/dev/archery[integration] | ||
|
||
# For C Data Interface testing | ||
pip install jpype1 pythonnet | ||
if [ "${ARROW_INTEGRATION_CSHARP}" == "ON" ]; then | ||
pip install pythonnet | ||
fi | ||
if [ "${ARROW_INTEGRATION_JAVA}" == "ON" ]; then | ||
pip install jpype1 | ||
fi | ||
|
||
# Get more detailed context on crashes | ||
export PYTHONFAULTHANDLER=1 | ||
|
@@ -34,11 +48,11 @@ time archery integration \ | |
--run-c-data \ | ||
--run-ipc \ | ||
--run-flight \ | ||
--with-cpp=1 \ | ||
--with-csharp=1 \ | ||
--with-java=1 \ | ||
--with-js=1 \ | ||
--with-go=1 \ | ||
--with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \ | ||
--with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \ | ||
--with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \ | ||
--with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \ | ||
--with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need a with-rust here in order to use this in arrow-rs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's no with-rust currently. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're currently using it - https://github.com/apache/arrow-rs/blob/master/.github/workflows/integration.yml#L121 I'll give the env variable a go as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahah... I don't know why we have both then. |
||
--gold-dirs=$gold_dir/0.14.1 \ | ||
--gold-dirs=$gold_dir/0.17.1 \ | ||
--gold-dirs=$gold_dir/1.0.0-bigendian \ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
#!/usr/bin/env bash | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
set -ex | ||
|
||
arrow_dir=${1} | ||
build_dir=${2} | ||
|
||
: ${ARROW_INTEGRATION_CPP:=ON} | ||
: ${ARROW_INTEGRATION_CSHARP:=ON} | ||
: ${ARROW_INTEGRATION_GO:=ON} | ||
: ${ARROW_INTEGRATION_JAVA:=ON} | ||
: ${ARROW_INTEGRATION_JS:=ON} | ||
|
||
${arrow_dir}/ci/scripts/rust_build.sh ${arrow_dir} ${build_dir} | ||
|
||
if [ "${ARROW_INTEGRATION_CPP}" == "ON" ]; then | ||
${arrow_dir}/ci/scripts/cpp_build.sh ${arrow_dir} ${build_dir} | ||
fi | ||
|
||
if [ "${ARROW_INTEGRATION_CSHARP}" == "ON" ]; then | ||
${arrow_dir}/ci/scripts/csharp_build.sh ${arrow_dir} ${build_dir} | ||
fi | ||
|
||
if [ "${ARROW_INTEGRATION_GO}" == "ON" ]; then | ||
${arrow_dir}/ci/scripts/go_build.sh ${arrow_dir} ${build_dir} | ||
fi | ||
|
||
if [ "${ARROW_INTEGRATION_JAVA}" == "ON" ]; then | ||
export ARROW_JAVA_CDATA="ON" | ||
export JAVA_JNI_CMAKE_ARGS="-DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF -DARROW_JAVA_JNI_ENABLE_C=ON" | ||
|
||
${arrow_dir}/ci/scripts/java_jni_build.sh ${arrow_dir} ${ARROW_HOME} ${build_dir} /tmp/dist/java/$(arch) | ||
${arrow_dir}/ci/scripts/java_build.sh ${arrow_dir} ${build_dir} /tmp/dist/java | ||
fi | ||
|
||
if [ "${ARROW_INTEGRATION_JS}" == "ON" ]; then | ||
${arrow_dir}/ci/scripts/js_build.sh ${arrow_dir} ${build_dir} | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this isn't used. Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, existing callers pass this...