GH-37069: [C#] Allow for record batches larger than 2 GB #38593
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -204,7 +204,7 @@ private void CreateBuffers<T>(PrimitiveArray<T> array) | |||
|
|
|||
| private Buffer CreateBuffer(ArrowBuffer buffer) | |||
| { | |||
| int offset = TotalLength; | |||
| int offset = checked((int)TotalLength); | |||
There was a problem hiding this comment.
Both "offset" and the properties in the Buffer class would also need to be changed to long.
github-actions
bot
added
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Allow for record batches larger than 2 GB.
What changes are included in this PR?
Make TotalLength a long instead of an int to allow for a larger record batch.
Are these changes tested?
Not yet, tests are WIP.
Potential issues:
Are there any user-facing changes?
No