Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38772: [C++] Implement directory semantics even when the storage account doesn't support HNS #39361

Merged
merged 24 commits into from
Jan 5, 2024
Merged

GH-38772: [C++] Implement directory semantics even when the storage account doesn't support HNS #39361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
682c885
FIX: Remove GTEST_SKIP() that would skip the second call with (false)
felipecrv Dec 22, 2023
899a724
Implement GetFileInfo with upfront HNS checking
felipecrv Dec 20, 2023
edc8035
Implement CreateDir with upfront HNS checks and directory semantics o…
felipecrv Dec 20, 2023
e7a36e1
Add comprehensive tests to CreateDir and delete tiny tests that would…
felipecrv Dec 21, 2023
045eb4d
Add HasSubmitBatchBug() to TestAzureFileSystem
felipecrv Dec 21, 2023
6e03984
Move all the HNS-only tests to all scenarios
felipecrv Dec 21, 2023
715781a
Fix DeleteDir bugs on Flat namespace storage accounts
felipecrv Dec 21, 2023
e9ea375
Split HNS and non-HNS code for the implementation of DeleteDir
felipecrv Dec 21, 2023
2748798
Extract DeleteDirContentsOnFileSystem from DeleteDirContents
felipecrv Dec 22, 2023
e9a1705
Flip name and meaning of boolean passed to DeleteDirContentsOnContainer
felipecrv Dec 23, 2023
ca28c0f
Add a local type alias for convenience
felipecrv Dec 23, 2023
ee12b7c
Simplify the use of DeleteDirContentsOnContainer by adding a bool param
felipecrv Dec 24, 2023
59e113d
Document a pre-condition of DeleteDirContentsOnContainer
felipecrv Dec 24, 2023
7b663b9
Declare all client parameters as const &
felipecrv Dec 24, 2023
8518476
Fix typo
felipecrv Dec 26, 2023
2a64996
Only call GetAzureEnv if env is used
felipecrv Dec 26, 2023
de2a768
Document the interpretation of the ListBlobByHierarchy response
felipecrv Dec 26, 2023
f091ad5
Add more information to some error messages
felipecrv Jan 4, 2024
2e4d4e0
Remove GetDirectoryClient tparam from CreateDirTemplate
felipecrv Jan 4, 2024
5203071
Extract EnsureEmptyDirExistsImplThatThrows and use it in two places
felipecrv Jan 4, 2024
8e2e9ff
Fix typo
felipecrv Jan 4, 2024
9957577
Nest second kContainerNotFound check
felipecrv Jan 4, 2024
96bdba2
Attach metadata to directory marker blobs
felipecrv Jan 4, 2024
432dd61
Fix test-code that doesn't match the expectations
felipecrv Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading