GH-39227: [C++][Parquet] new Boolean RecordReader geting raw LSB bitmap #40885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
|
It's not very pretty, but I think it's ok. |
wgtmac
reviewed
Mar 29, 2024
| static std::shared_ptr<RecordReader> Make( | ||
| const ColumnDescriptor* descr, LevelInfo leaf_info, | ||
| ::arrow::MemoryPool* pool = ::arrow::default_memory_pool(), | ||
| bool read_dictionary = false, bool read_dense_for_nullable = false); | ||
| bool read_dictionary = false, bool read_dense_for_nullable = false, |
There was a problem hiding this comment.
These parameters are enough to have a new RecordReaderOptions, IMHO.
github-actions
bot
added
awaiting committer review
wgtmac
reviewed
Mar 29, 2024
| @@ -487,6 +494,11 @@ class DictionaryRecordReader : virtual public RecordReader { | |||
| virtual std::shared_ptr<::arrow::ChunkedArray> GetResult() = 0; | |||
| }; | |||
|
|
|||
| class BitmapBooleanRecordReader : virtual public RecordReader { | |||
| public: | |||
| virtual std::shared_ptr<::arrow::Array> GetChunkedData() = 0; | |||
There was a problem hiding this comment.
I'm not sure if making it an explicit BooleanArray is a good idea. In this case, we can simply call it BooleanRecordReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?