Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41390: [CI] Use setup-python GitHub action on csharp macOS job #41392

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Apr 26, 2024

Rationale for this change

The new macos-latest GH runner has changed and jobs are currently failing.

What changes are included in this PR?

Install python with setup-python.

Are these changes tested?

Will be on CI

Are there any user-facing changes?

No

@raulcd raulcd requested review from assignUser and kou as code owners April 26, 2024 14:51
Copy link

⚠️ GitHub issue #41390 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 26, 2024
@raulcd
Copy link
Member Author

raulcd commented Apr 26, 2024

@CurtHagenlocher there seems to be an error with .net 8 on that job now that I fixed Python:

Passed!  - Failed:     0, Passed:    25, Skipped:     0, Total:    25, Duration: 279 ms - Apache.Arrow.Compression.Tests.dll (net8.0)
The active test run was aborted. Reason: Test host process crashed : Stack overflow.
   at Python.Runtime.Runtime.PyImport_ImportModule(System.String)
   at Python.Runtime.PyModule.Import(System.String)
   at Python.Runtime.Py.Import(System.String)
   at Apache.Arrow.Tests.CDataSchemaPythonTest.ImportRecordBatchFromBuffer()
   at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(System.Object, System.Reflection.BindingFlags)
   at Xunit.Sdk.TestInvoker`1[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].CallTestMethod(System.Object)
   at Xunit.Sdk.TestInvoker`1+<>c__DisplayClass46_0+<<InvokeTestMethodAsync>b__1>d[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Xunit.Sdk.TestInvoker`1+<>c__DisplayClass46_0+<<InvokeTestMethodAsync>b__1>d[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], xunit.execution.dotnet, Version=2.7.1.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]](<<InvokeTestMethodAsync>b__1>d<System.__Canon> ByRef)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Xunit.Sdk.TestInvoker`1+<>c__DisplayClass46_0+<<InvokeTestMethodAsync>b__1>d[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], xunit.execution.dotnet, Version=2.7.1.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]](<<InvokeTestMethodAsync>b__1>d<System.__Canon> ByRef)
   at Xunit.Sdk.TestInvoker`1+<>c__DisplayClass46_0[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<InvokeTestMethodAsync>b__1()
   at Xunit.Sdk.ExecutionTimer+<AggregateAsync>d__4.MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Xunit.Sdk.ExecutionTimer+<AggregateAsync>d__4, xunit.execution.dotnet, Version=2.7.1.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]](<AggregateAsync>d__4 ByRef)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Xunit.Sdk.ExecutionTimer+<AggregateAsync>d__4, xunit.execution.dotnet, Version=2.7.1.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]](<AggregateAsync>d__4 ByRef)
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(System.Func`1<System.Threading.Tasks.Task>)
   at Xunit.Sdk.TestInvoker`1+<>c__DisplayClass46_0[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<InvokeTestMethodAsync>b__0()
   at Xunit.Sdk.ExceptionAggregator+<RunAsync>d__9.MoveNext()

I am unsure on what the issue is.

@CurtHagenlocher
Copy link
Contributor

Thanks @raulcd. I'll take a look.

@CurtHagenlocher
Copy link
Contributor

I can confirm that this repros locally on my M1 Mac.

@raulcd
Copy link
Member Author

raulcd commented Apr 26, 2024

Thanks @CurtHagenlocher , I am happy to both merge this and fix the issue on a different PR or you can pick this change and provide the .NET fix on a separate one :)

@CurtHagenlocher
Copy link
Contributor

I filed #41397 for the test failure. I can repro it even with an older maintenance branch using .NET 7.0 so there seems to be something more going on than just the .NET upgrade. I think this PR should be committed while I try to figure things out.

Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merging as discussed on the PR.

@raulcd raulcd merged commit 15986ae into apache:main Apr 26, 2024
8 of 9 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Apr 26, 2024
@github-actions github-actions bot added the awaiting changes Awaiting changes label Apr 26, 2024
@raulcd raulcd deleted the GH-41390 branch April 26, 2024 17:14
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 15986ae.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…ob (apache#41392)

### Rationale for this change

The new macos-latest GH runner has changed and jobs are currently failing.

### What changes are included in this PR?

Install python with setup-python.

### Are these changes tested?

Will be on CI

### Are there any user-facing changes?
No
* GitHub Issue: apache#41390

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ob (apache#41392)

### Rationale for this change

The new macos-latest GH runner has changed and jobs are currently failing.

### What changes are included in this PR?

Install python with setup-python.

### Are these changes tested?

Will be on CI

### Are there any user-facing changes?
No
* GitHub Issue: apache#41390

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants