-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41390: [CI] Use setup-python GitHub action on csharp macOS job #41392
Conversation
|
@CurtHagenlocher there seems to be an error with .net 8 on that job now that I fixed Python:
I am unsure on what the issue is. |
Thanks @raulcd. I'll take a look. |
I can confirm that this repros locally on my M1 Mac. |
Thanks @CurtHagenlocher , I am happy to both merge this and fix the issue on a different PR or you can pick this change and provide the .NET fix on a separate one :) |
I filed #41397 for the test failure. I can repro it even with an older maintenance branch using .NET 7.0 so there seems to be something more going on than just the .NET upgrade. I think this PR should be committed while I try to figure things out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 merging as discussed on the PR.
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 15986ae. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ob (apache#41392) ### Rationale for this change The new macos-latest GH runner has changed and jobs are currently failing. ### What changes are included in this PR? Install python with setup-python. ### Are these changes tested? Will be on CI ### Are there any user-facing changes? No * GitHub Issue: apache#41390 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…ob (apache#41392) ### Rationale for this change The new macos-latest GH runner has changed and jobs are currently failing. ### What changes are included in this PR? Install python with setup-python. ### Are these changes tested? Will be on CI ### Are there any user-facing changes? No * GitHub Issue: apache#41390 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
The new macos-latest GH runner has changed and jobs are currently failing.
What changes are included in this PR?
Install python with setup-python.
Are these changes tested?
Will be on CI
Are there any user-facing changes?
No