GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

sgilmore10 · 2024-05-15T17:22:55Z

Rationale for this change

In #41592, we added a CI job to build and test the MATLAB interface on macos-14, which is ARM-based. We currently only package the interface on macos-12, which is Intel-based.

We should add a crossbow job to package the MATLAB interface on macos-14 so that we package the interface for both Intel-based and ARM-based macoS.

What changes are included in this PR?

Parameterized the macos job in the MATLAB crossbow workflow file to run on both macos-12 and macos-14.
Added the bash script dev/tasks/matlab/rename_macos_dynamic_libraries.sh. This script is used to uniquify the shared library names generated for the Intel/AMD-based macOS and ARM-based macOS interface installations. This is required because the crossbow job generates one "monolithic" MLTBX file that contains all shared libraries for all platforms. See the comment at the beginning of dev/tasks/matlab/rename_macos_dynamic_libraries.sh for a more in-depth explanation.

Are these changes tested?

Installed the MATLAB Arrow Interface on both Intel-based and ARM-based macOS machines using the MLTBX file generated by this crossbow job. All unit tests passed.

Are there any user-facing changes?

Users on ARM-based macOS machines will be able to install the MATLAB Arrow Interface via a "one-click" install
workflow using the MLTBX file.

GitHub Issue: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41675

sgilmore10 · 2024-05-15T18:06:23Z

@github-actions crossbow submit matlab

github-actions · 2024-05-15T18:08:47Z

Revision: 0a9adea

Submitted crossbow builds: ursacomputing/crossbow @ actions-2c74dc47d1

Task	Status
matlab

sgilmore10 · 2024-05-15T18:21:53Z

@github-actions crossbow submit matlab

github-actions · 2024-05-15T18:24:09Z

Revision: 4166464

Submitted crossbow builds: ursacomputing/crossbow @ actions-73015ffe49

Task	Status
matlab

sgilmore10 · 2024-05-15T18:34:25Z

@github-actions crossbow submit matlab

github-actions · 2024-05-15T18:37:03Z

Revision: daf8557

Submitted crossbow builds: ursacomputing/crossbow @ actions-75ef64fd55

Task	Status
matlab

sgilmore10 · 2024-05-16T17:47:06Z

@github-actions crossbow submit matlab

github-actions · 2024-05-16T17:49:22Z

Revision: a444c7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-ee0e0dc048

Task	Status
matlab

sgilmore10 · 2024-05-16T21:06:24Z

@github-actions crossbow submit matlab

github-actions · 2024-05-16T21:08:56Z

Revision: 3e0d9a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-f3e6a4f210

Task	Status
matlab

sgilmore10 · 2024-05-24T19:52:08Z

@github-actions crossbow submit matlab

github-actions · 2024-05-24T19:54:25Z

Revision: e1b3b9f

Submitted crossbow builds: ursacomputing/crossbow @ actions-e50cfc7cb8

Task	Status
matlab

sgilmore10 · 2024-05-24T20:13:38Z

@github-actions crossbow submit matlab

github-actions · 2024-05-24T20:15:58Z

Revision: 955c70b

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f1fb0e2cd

Task	Status
matlab

sgilmore10 · 2024-05-28T17:55:28Z

@github-actions crossbow submit matlab

github-actions · 2024-05-28T17:57:44Z

Revision: 7fd016a

Submitted crossbow builds: ursacomputing/crossbow @ actions-774ecfa005

Task	Status
matlab

sgilmore10 · 2024-05-28T18:07:04Z

@github-actions crossbow submit matlab

github-actions · 2024-05-28T18:09:20Z

Revision: cf7b6e1

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b09295f7a

Task	Status
matlab

kou

+1

dev/tasks/matlab/github.yml

dev/tasks/matlab/rename_macos_dynamic_libraries.sh

Co-authored-by: Sutou Kouhei <[email protected]>

sgilmore10 · 2024-05-29T13:26:28Z

@github-actions crossbow submit matlab

github-actions · 2024-05-29T13:28:43Z

Revision: f0a048c

Submitted crossbow builds: ursacomputing/crossbow @ actions-aabbba2f3f

Task	Status
matlab

sgilmore10 · 2024-05-29T13:35:51Z

@github-actions crossbow submit matlab

github-actions · 2024-05-29T13:38:08Z

Revision: 7958cf1

Submitted crossbow builds: ursacomputing/crossbow @ actions-b1f520b25d

Task	Status
matlab

sgilmore10 · 2024-05-29T13:44:51Z

@github-actions crossbow submit matlab

github-actions · 2024-05-29T13:47:05Z

Revision: 1e339d7

Submitted crossbow builds: ursacomputing/crossbow @ actions-880a0245bd

Task	Status
matlab

sgilmore10 · 2024-05-29T14:29:00Z

Re-ran the crossbow job with the new changes. Everything passed.

conbench-apache-arrow · 2024-06-06T10:16:27Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4a2df66.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 37 possible false positives for unstable benchmarks that are known to sometimes produce them.

Add macos-14 crossbow job

2a5332c

github-actions bot added the awaiting review Awaiting review label May 15, 2024

sgilmore10 added 3 commits May 15, 2024 13:49

Add script to rename dylibs on maca64

1d33bcc

Remove unused variable

46b4a22

call rename_macos_arm64_dylibs.sh script in crossbow macos-14 job

0a9adea

Fix yml indentation

4166464

Fix Upload artifacts step in macos-arm64 job

daf8557

sgilmore10 added 2 commits May 15, 2024 16:57

Add comment explaining the symbolic link issue

e14238d

Add comment explaining the shared library renaming

a444c7d

sgilmore10 added 3 commits May 16, 2024 16:51

Rename macos job to macos-x64

b61e100

Add generic script to rename libraries on ARM and Intel based macOS

b875705

Use rename_macos_dynamic_libraries

3e0d9a1

sgilmore10 added 3 commits May 24, 2024 15:50

Update comments

bebf23a

Delete rename_macos_arm64_dylibs.sh

f909bcb

Remove extra newline

e1b3b9f

Fix tar file name created on macOS 12

955c70b

Add missing space after [ and before ]

cf7b6e1

sgilmore10 marked this pull request as ready for review May 28, 2024 18:42

sgilmore10 requested review from assignUser, kou and raulcd as code owners May 28, 2024 18:42

kou approved these changes May 29, 2024

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 29, 2024

sgilmore10 and others added 2 commits May 29, 2024 09:21

Update dev/tasks/matlab/github.yml

6588c0f

Co-authored-by: Sutou Kouhei <[email protected]>

Don't use arch variable

f0a048c

sgilmore10 added 3 commits May 29, 2024 09:29

Specify macOS version in job name

34eeed2

Add missing {

f0fb235

Use pushd/popd

7958cf1

Delete cd call

1e339d7

sgilmore10 merged commit 4a2df66 into apache:main May 29, 2024
6 checks passed

sgilmore10 deleted the GH-41675 branch May 29, 2024 14:30

sgilmore10 removed the awaiting merge Awaiting merge label May 29, 2024

sgilmore10 mentioned this pull request May 29, 2024

[Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

sgilmore10 commented May 15, 2024 •

edited

Loading

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 16, 2024

github-actions bot commented May 16, 2024

sgilmore10 commented May 16, 2024

github-actions bot commented May 16, 2024

sgilmore10 commented May 24, 2024

github-actions bot commented May 24, 2024

sgilmore10 commented May 24, 2024

github-actions bot commented May 24, 2024

sgilmore10 commented May 28, 2024

github-actions bot commented May 28, 2024

sgilmore10 commented May 28, 2024

github-actions bot commented May 28, 2024

kou left a comment

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

conbench-apache-arrow bot commented Jun 6, 2024

GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

Conversation

sgilmore10 commented May 15, 2024 • edited Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 15, 2024

github-actions bot commented May 15, 2024

sgilmore10 commented May 16, 2024

github-actions bot commented May 16, 2024

sgilmore10 commented May 16, 2024

github-actions bot commented May 16, 2024

sgilmore10 commented May 24, 2024

github-actions bot commented May 24, 2024

sgilmore10 commented May 24, 2024

github-actions bot commented May 24, 2024

sgilmore10 commented May 28, 2024

github-actions bot commented May 28, 2024

sgilmore10 commented May 28, 2024

github-actions bot commented May 28, 2024

kou left a comment

Choose a reason for hiding this comment

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

github-actions bot commented May 29, 2024

sgilmore10 commented May 29, 2024

conbench-apache-arrow bot commented Jun 6, 2024

sgilmore10 commented May 15, 2024 •

edited

Loading