-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41664: [C++][Python] PrettyPrint non-cpu data by copying to default CPU device #42010
Merged
jorisvandenbossche
merged 12 commits into
apache:main
from
jorisvandenbossche:gh-41664-pretty-print-non-cpu
Jun 26, 2024
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7890c00
GH-41664: PrettyPrint non-cpu data by copying slice to default CPU de…
jorisvandenbossche 050fd9d
fix for chunked array + add python tests
jorisvandenbossche 1c09d52
formatting
jorisvandenbossche 9ab291d
Merge remote-tracking branch 'upstream/main' into gh-41664-pretty-pri…
jorisvandenbossche 85fb619
Merge remote-tracking branch 'upstream/main' into gh-41664-pretty-pri…
jorisvandenbossche 595ad89
simplify approach (just copy full array instead of slice+concat)
jorisvandenbossche c57c2bc
Merge remote-tracking branch 'upstream/main' into gh-41664-pretty-pri…
jorisvandenbossche 555f8b6
move device check into ArrayPrinter::Print
jorisvandenbossche b129fdc
Merge remote-tracking branch 'upstream/main' into gh-41664-pretty-pri…
jorisvandenbossche 1b64ccf
remove assert_cpu now repr work
jorisvandenbossche fe82b3e
add TODO comment
jorisvandenbossche c65c7a5
Update cpp/src/arrow/pretty_print.cc
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a bit verbose, but can be simplified once the "copy to device" functionality is exposed (should maybe do that first now)