-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42017: [CI][Python][C++] Fix utf8proc detection for wheel on Windows #42022
Conversation
@github-actions crossbow submit wheel-windows-cp310-amd64 |
|
This comment was marked as outdated.
This comment was marked as outdated.
9551459
to
6fe7fb8
Compare
@github-actions crossbow submit wheel-windows-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
e261175
to
963983a
Compare
@github-actions crossbow submit wheel-windows-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
35a5068
to
6fcc411
Compare
@github-actions crossbow submit wheel-windows-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
6fcc411
to
980ffd5
Compare
@github-actions crossbow submit wheel-windows-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
980ffd5
to
4b95f3c
Compare
@github-actions crossbow submit wheel-windows-* java-jars |
Revision: 4b95f3c Submitted crossbow builds: ursacomputing/crossbow @ actions-807f5191c1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kou ! LGTM
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1dde399. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
utf8proc in vcpkg provides CMake package. If we use it, we don't need to care about static library name (
utf8proc.lib
orutf8proc_static.lib
).What changes are included in this PR?
Use
unofficial-utf8proc
CMake package with vcpkg.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Could NOT find utf8proc (missing: utf8proc_LIB) (found suitable version "2.7.0", minimum required is "2.2.0")
#42017