Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42017: [CI][Python][C++] Fix utf8proc detection for wheel on Windows #42022

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

kou
Copy link
Member

@kou kou commented Jun 6, 2024

Rationale for this change

utf8proc in vcpkg provides CMake package. If we use it, we don't need to care about static library name (utf8proc.lib or utf8proc_static.lib).

What changes are included in this PR?

Use unofficial-utf8proc CMake package with vcpkg.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners June 6, 2024 21:04
@kou
Copy link
Member Author

kou commented Jun 6, 2024

@github-actions crossbow submit wheel-windows-cp310-amd64

Copy link

github-actions bot commented Jun 6, 2024

⚠️ GitHub issue #42017 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 6, 2024

This comment was marked as outdated.

@kou kou force-pushed the python-wheel-windows-utf8proc branch from 9551459 to 6fe7fb8 Compare June 6, 2024 21:08
@kou
Copy link
Member Author

kou commented Jun 6, 2024

@github-actions crossbow submit wheel-windows-cp310-amd64

This comment was marked as outdated.

@kou kou force-pushed the python-wheel-windows-utf8proc branch 5 times, most recently from e261175 to 963983a Compare June 7, 2024 00:27
@kou
Copy link
Member Author

kou commented Jun 7, 2024

@github-actions crossbow submit wheel-windows-cp310-amd64

This comment was marked as outdated.

@kou kou force-pushed the python-wheel-windows-utf8proc branch 2 times, most recently from 35a5068 to 6fcc411 Compare June 7, 2024 00:41
@kou
Copy link
Member Author

kou commented Jun 7, 2024

@github-actions crossbow submit wheel-windows-cp310-amd64

This comment was marked as outdated.

@kou kou force-pushed the python-wheel-windows-utf8proc branch from 6fcc411 to 980ffd5 Compare June 7, 2024 03:04
@kou
Copy link
Member Author

kou commented Jun 7, 2024

@github-actions crossbow submit wheel-windows-cp310-amd64

This comment was marked as outdated.

@kou kou force-pushed the python-wheel-windows-utf8proc branch from 980ffd5 to 4b95f3c Compare June 7, 2024 04:07
@kou
Copy link
Member Author

kou commented Jun 7, 2024

@github-actions crossbow submit wheel-windows-* java-jars

Copy link

github-actions bot commented Jun 7, 2024

Revision: 4b95f3c

Submitted crossbow builds: ursacomputing/crossbow @ actions-807f5191c1

Task Status
java-jars GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou ! LGTM

@raulcd raulcd merged commit 1dde399 into apache:main Jun 7, 2024
37 checks passed
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1dde399.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants