GH-42235: [C++] list_parent_indices: Add support for list-view types #42236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Documentation
awaiting committer review
pitrou
reviewed
Jun 24, 2024
| auto input = | ||
| ArrayFromJSON(list_view(int16()), "[[0, null, 1], [0, 0], [2, 3], [], [4, 5]]"); | ||
| auto tweaked = TweakValidityBit(input, 1, false); | ||
| auto expected = ArrayFromJSON(int64(), "[0, 0, 0, null, null, 2, 2, 4, 4]"); |
There was a problem hiding this comment.
Hmm... the fact that this gives a different result than for regular lists should perhaps be called out in the official documentation for this function?
There was a problem hiding this comment.
Done. Tell me if it's clear enough.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
pitrou
approved these changes
Jun 25, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 508bdaa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Jul 9, 2024
…types (apache#42236) ### Rationale for this change Completing the support of list-views. ### What changes are included in this PR? Implementation of the `list_parent_indices` function for `ListViewType` and `LargeListViewType`. ### Are these changes tested? Yes, by new unit tests. ### Are there any user-facing changes? More complete support of list-views. * GitHub Issue: apache#42235 Lead-authored-by: Felipe Oliveira Carvalho <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Completing the support of list-views.
What changes are included in this PR?
Implementation of the
list_parent_indicesfunction forListViewTypeandLargeListViewType.Are these changes tested?
Yes, by new unit tests.
Are there any user-facing changes?
More complete support of list-views.