GH-43305: [FlightRPC][Java] Invocation of close method from ArrowFlightConnection throws a SQLException when using catalog as parameter #43306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SQLException when using catalog as parameter #43305
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Changes for solving issue apache/arrow-java#66. See that issue for details of the problem.
What changes are included in this PR?
Do not close the
clientHandlertwice atorg.apache.arrow.driver.jdbc.ArrowFlightConnection#close. Second call should be removed because itclientHandleris already closed and the executor is shutdown.Also, I changed the condition for calling to
org.apache.arrow.flight.sql.FlightSqlClient#closeSessionmethod. I do not see a reason why it has to be done only with thecatalogwas set.Are these changes tested?
Still TODO. PR marked as draft for this reason.
Are there any user-facing changes?
Users can start to receive a SQLException when calling
org.apache.arrow.driver.jdbc.ArrowFlightConnection#close.