Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43907: [C#][FlightRPC] Add Grpc Call Options support on Flight Client #43910

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

qmmk
Copy link
Contributor

@qmmk qmmk commented Sep 2, 2024

Rationale for this change

This implementation add default grpc call options on the csharp implementation FlightClient

What changes are included in this PR?

  • FlightClient.cs with updated signature for all the methods accepting grpc call options
  • FlightTest.cs update test to verify the raise of the right exception

Are these changes tested?

Yes, tests are added in FlightTest.cs
I've tested locally with the C++ implementation.

Are there any user-facing changes?

No is transparent for the user, following the already present documentation should be sufficient.

References

Copy link

github-actions bot commented Sep 2, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@qmmk qmmk changed the title Add Grpc Call Options support on Flight Client Add Grpc Call Options support on Flight Client GH-40690: [C#][FlightRPC] Add do_exchange csharp implementation Sep 2, 2024
@qmmk qmmk changed the title Add Grpc Call Options support on Flight Client GH-40690: [C#][FlightRPC] Add do_exchange csharp implementation GH-43907: [C#][FlightRPC]: Add Grpc Call Options support on Flight Client Sep 2, 2024
@qmmk qmmk changed the title GH-43907: [C#][FlightRPC]: Add Grpc Call Options support on Flight Client GH-43907: [C#][FlightRPC] Add Grpc Call Options support on Flight Client Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

⚠️ GitHub issue #43907 has been automatically assigned in GitHub to PR creator.

Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think the binary-compatibility change is required; the others I leave to your discretion.

csharp/src/Apache.Arrow.Flight/Client/FlightClient.cs Outdated Show resolved Hide resolved
csharp/src/Apache.Arrow.Flight/Client/FlightClient.cs Outdated Show resolved Hide resolved
csharp/test/Apache.Arrow.Flight.Tests/FlightTests.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 2, 2024
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit b0786d4 into apache:main Sep 3, 2024
10 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting committer review Awaiting committer review label Sep 3, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b0786d4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Sep 6, 2024
…ht Client (apache#43910)

### Rationale for this change

This implementation add default grpc call options on the csharp implementation FlightClient

### What changes are included in this PR?

- FlightClient.cs with updated signature for all the methods accepting grpc call options
- FlightTest.cs update test to verify the raise of the right exception

### Are these changes tested?

Yes, tests are added in FlightTest.cs
I've tested locally with the C++ implementation.

### Are there any user-facing changes?

No is transparent for the user, following the already present documentation should be sufficient.

### References

* GitHub Issue: apache#43907

Authored-by: Marco Malagoli <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…ht Client (apache#43910)

### Rationale for this change

This implementation add default grpc call options on the csharp implementation FlightClient

### What changes are included in this PR?

- FlightClient.cs with updated signature for all the methods accepting grpc call options
- FlightTest.cs update test to verify the raise of the right exception

### Are these changes tested?

Yes, tests are added in FlightTest.cs
I've tested locally with the C++ implementation.

### Are there any user-facing changes?

No is transparent for the user, following the already present documentation should be sufficient.

### References

* GitHub Issue: apache#43907

Authored-by: Marco Malagoli <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants