-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43907: [C#][FlightRPC] Add Grpc Call Options support on Flight Client #43910
GH-43907: [C#][FlightRPC] Add Grpc Call Options support on Flight Client #43910
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I think the binary-compatibility change is required; the others I leave to your discretion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b0786d4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ht Client (apache#43910) ### Rationale for this change This implementation add default grpc call options on the csharp implementation FlightClient ### What changes are included in this PR? - FlightClient.cs with updated signature for all the methods accepting grpc call options - FlightTest.cs update test to verify the raise of the right exception ### Are these changes tested? Yes, tests are added in FlightTest.cs I've tested locally with the C++ implementation. ### Are there any user-facing changes? No is transparent for the user, following the already present documentation should be sufficient. ### References * GitHub Issue: apache#43907 Authored-by: Marco Malagoli <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
…ht Client (apache#43910) ### Rationale for this change This implementation add default grpc call options on the csharp implementation FlightClient ### What changes are included in this PR? - FlightClient.cs with updated signature for all the methods accepting grpc call options - FlightTest.cs update test to verify the raise of the right exception ### Are these changes tested? Yes, tests are added in FlightTest.cs I've tested locally with the C++ implementation. ### Are there any user-facing changes? No is transparent for the user, following the already present documentation should be sufficient. ### References * GitHub Issue: apache#43907 Authored-by: Marco Malagoli <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Rationale for this change
This implementation add default grpc call options on the csharp implementation FlightClient
What changes are included in this PR?
Are these changes tested?
Yes, tests are added in FlightTest.cs
I've tested locally with the C++ implementation.
Are there any user-facing changes?
No is transparent for the user, following the already present documentation should be sufficient.
References