-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43518: [Python][Packaging][CI] Drop Python 3.8 support #43970
Conversation
.github/workflows/go.yml
Outdated
@@ -209,7 +209,7 @@ jobs: | |||
- name: Setup Python | |||
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0 | |||
with: | |||
python-version: 3.8 | |||
python-version: 3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump this directly to something like 3.12? As far as I understand, this python version is only used for running archery, so it shouldn't matter much which version we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I had the same thought, I will update accordingly. Another one that I was thinking is whether we want to change the default .env
to be bumped too to something like 3.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using the latest Python by 3.x
for this? If we can use 3.x
for this, we don't need to bump version periodically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use 3.x
, though, the build may fail because of missing dependencies or incompatibilities on the next version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've bumped to 3.12
Would it make sense to drop most of the pytz support in favor of zoneinfo available starting 3.9? |
This can be done on a separate issue as an enhancement |
@jorisvandenbossche we are still testing with Pandas 1.0 which supports only up to Python 3.8. Should I remove that job from here: https://github.com/apache/arrow/blob/main/.github/workflows/python.yml#L81 |
@github-actions crossbow submit -g python |
Revision: 7f7ed83 Submitted crossbow builds: ursacomputing/crossbow @ actions-b0516a9194 |
@github-actions crossbow submit test-ubuntu-20.04-python-3 |
Revision: 6417ba8 Submitted crossbow builds: ursacomputing/crossbow @ actions-bea836645b
|
@github-actions crossbow submit test-conda-python--pandas- |
Revision: cceb42c Submitted crossbow builds: ursacomputing/crossbow @ actions-92763bccf5 |
@github-actions crossbow submit test-cuda-* |
@github-actions crossbow -g wheel |
Revision: e38f0ec Submitted crossbow builds: ursacomputing/crossbow @ actions-cea603844a
|
|
@github-actions crossbow submit -g wheel |
Revision: e38f0ec Submitted crossbow builds: ursacomputing/crossbow @ actions-5c11026f84 |
@github-actions crossbow submit test-cuda-* |
Revision: f1d50d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-ddf92023c8
|
@github-actions crossbow submit python-sdist |
Revision: af0c193 Submitted crossbow builds: ursacomputing/crossbow @ actions-fe84520036
|
Revision: deb83bf Submitted crossbow builds: ursacomputing/crossbow @ actions-b2844258b5 |
@github-actions crossbow submit -g cuda |
@github-actions crossbow submit test-ubuntu-*-python-3 |
@github-actions crossbow submit test-conda-python-3.9-pandas-* |
Revision: 336b9bb Submitted crossbow builds: ursacomputing/crossbow @ actions-bb81803d22
|
Revision: 336b9bb Submitted crossbow builds: ursacomputing/crossbow @ actions-579ae18356
|
Revision: 336b9bb Submitted crossbow builds: ursacomputing/crossbow @ actions-074cb676c3
|
@github-actions crossbow submit -g cuda |
Revision: 4f1cd9c Submitted crossbow builds: ursacomputing/crossbow @ actions-9c860297b0
|
@github-actions crossbow submit -g wheel |
Revision: 4f1cd9c Submitted crossbow builds: ursacomputing/crossbow @ actions-5f28e2f3a2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @raulcd . @jorisvandenbossche can you validate the Pandas / Numpy changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I opened the follow-up issue to properly bump the numpy and pandas versions: #44131 |
The wheel-windows-cp313-amd64 failure is temporary because of a missing nightly wheel from the pandas side, which should be fixed by tomorrow. But so ignoring that for now, and merging this. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aa6ab95. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Python 3.8 is End of Support on 31st October 2023. We can drop support for pyarrow 18.0.0.
See: https://endoflife.date/python
What changes are included in this PR?
Remove support for 3.8. Update minimum required Python version and update some CI jobs to use the minimum Python supported version
Are these changes tested?
They will be tested via Archery
Are there any user-facing changes?
Yes in terms of not supporting older versions of Python. This will be a breaking change for some users but not for the API itself