-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43956: [Format] Allow Decimal32/Decimal64 in format #43976
Merged
zeroshade
merged 3 commits into
apache:main
from
zeroshade:expand-decimal-bitwidth-format
Sep 10, 2024
Merged
GH-43956: [Format] Allow Decimal32/Decimal64 in format #43976
zeroshade
merged 3 commits into
apache:main
from
zeroshade:expand-decimal-bitwidth-format
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
awaiting committer review
Awaiting committer review
labels
Sep 5, 2024
lidavidm
approved these changes
Sep 6, 2024
github-actions
bot
added
awaiting merge
Awaiting merge
and removed
awaiting committer review
Awaiting committer review
labels
Sep 6, 2024
bkietz
approved these changes
Sep 10, 2024
pitrou
requested changes
Sep 10, 2024
github-actions
bot
added
awaiting changes
Awaiting changes
and removed
awaiting merge
Awaiting merge
labels
Sep 10, 2024
pitrou
reviewed
Sep 10, 2024
Co-authored-by: Antoine Pitrou <[email protected]>
github-actions
bot
added
awaiting change review
Awaiting change review
and removed
awaiting changes
Awaiting changes
labels
Sep 10, 2024
pitrou
approved these changes
Sep 10, 2024
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c4b68ee. There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 119 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…43976) ### Rationale for this change Widening the Decimal128/256 type to allow for bitwidths of 32 and 64 allows for more interoperability with other libraries and utilities which already support these types. This provides even more opportunities for zero-copy interactions between things such as libcudf and various databases. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ### What changes are included in this PR? Updating the documentation in Schema.fbs to explicitly state that 32-bit and 64-bit is now allowed for bitwidths of Decimal types. This is the only area in the the spec that mentions the allowed decimal bitwidths. * GitHub Issue: apache#43956 --------- Co-authored-by: Antoine Pitrou <[email protected]>
kou
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes a minor docs omission from #43976. Authored-by: Ian Cook <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zeroshade
added a commit
to zeroshade/arrow
that referenced
this pull request
Sep 30, 2024
…43976) Widening the Decimal128/256 type to allow for bitwidths of 32 and 64 allows for more interoperability with other libraries and utilities which already support these types. This provides even more opportunities for zero-copy interactions between things such as libcudf and various databases. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Updating the documentation in Schema.fbs to explicitly state that 32-bit and 64-bit is now allowed for bitwidths of Decimal types. This is the only area in the the spec that mentions the allowed decimal bitwidths. * GitHub Issue: apache#43956 --------- Co-authored-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Widening the Decimal128/256 type to allow for bitwidths of 32 and 64 allows for more interoperability with other libraries and utilities which already support these types. This provides even more opportunities for zero-copy interactions between things such as libcudf and various databases.
What changes are included in this PR?
Updating the documentation in Schema.fbs to explicitly state that 32-bit and 64-bit is now allowed for bitwidths of Decimal types. This is the only area in the the spec that mentions the allowed decimal bitwidths.